Update log4j.properties.epp #339
Open
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using this module for our project but it does not accept the parameter kafka.logs.dir since it is not initialised in the param.pp. Either you include it or accept this change.
|
@bastelfreak could you please have a look? |
kenyon
requested changes
Nov 12, 2022
There was a problem hiding this comment.
${log_dir} won't be replaced with its value unless it's in EPP templating delimiters <%= %>, and the variable is passed to the template in the epp() function, or the variable is fully-qualified. Also we need #336 so that the tests pass.
|
@kenyon Thank for you review, i have done the requested changes , could you please review it? |
kenyon
requested changes
Nov 13, 2022
|
@kenyon done, please have a look. |
kenyon
requested changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues