-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept mapped_paths #285
base: master
Are you sure you want to change the base?
Accept mapped_paths #285
Conversation
mapped_paths: | ||
- "<%= $hr['mapped_paths'][0] %>" | ||
- "<%= $hr['mapped_paths'][1] %>" | ||
- "<%= $hr['mapped_paths'][2] %>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there three of these instead of iterating over however many might be in the array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.. because that's how it works :)
https://puppet.com/docs/puppet/latest/hiera_config_yaml_5.html#specifying_file_paths
"The mapped_paths key must contain three string elements, in the following order:
A scope variable that points to a collection of strings.
The variable name that is mapped to each element of the collection.
A template where that variable can be used in interpolation expressions."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Garrett, just wondering when do you believe it can be pushed up.
Thanks for the contribution! This will need tests in order to be merged. |
Are the tests done ? |
No, someone needs to write them and add them to this pull request. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues