Fix276 #289
Open
Fix276 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check direct rules existence in both runtime and permanent - Put all provider direct rules unit tests in firewalld_direct_rule_spec.rb
- Check direct rules existence in both runtime and permanent
- Check direct rules existence in both runtime and permanent - fix wrong chain_args value in direct chain spec - put all direct passthrough provider unit tests in its corresponding file
- Check rich provider rules existence in both runtime and permanent - put all rich rule provider unit tests in provider spec file
- Check rich provider rules existence in both runtime and permanent - put all rich rule provider unit tests in provider spec file
- Check port's existence in both runtime and permanent
|
Dear @isqo, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
…into FIX276 # Conflicts: # spec/unit/puppet/type/firewalld_rich_rule_spec.rb
|
@isqo any status on this PR? |
|
@lvthillo being a little bit tied up at work, I'll try to rebase it this month. |
|
Is this still viable? I'd love to have it in if so.... |
|
Just checking back in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request allows the reload of firewalld rules to get triggered when they are not present in the runtime stage of firewalld and are only present in permanent. It fixes the rules that get stuck in permanent stage because of a skipped reload caused by a puppet error between the deployment of rules and the reload.
This Pull Request (PR) fixes the following issues
Fixes #276