Fixed recursive call of assertion errors which led to a huge delay wh…

…en a test failed - Fixes #278
vowsjs · Nov 17, 2014 · 5dced8e · 5dced8e
1 parent bc7cad0
commit 5dced8e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/assert/error.js b/lib/assert/error.js
@@ -75,7 +75,12 @@ function errorDiff(err, type) {
   }).join('');
 }
 
-require('assert').AssertionError.prototype.toString = function () {
+/*
+ Do not override .toString() when this.stack is used,
+ otherwise this will end in an endless recursive call...
+ See issue https://github.com/cloudhead/vows/issues/278#issuecomment-22837493
+*/
+require('assert').AssertionError.prototype.toStringEx = function () {
     var that = this,
         source;
 

diff --git a/lib/vows.js b/lib/vows.js
@@ -136,7 +136,7 @@ function addVow(vow) {
             output('honored');
         } catch (e) {
             if (e.name && e.name.match(/AssertionError/)) {
-                output('broken', e.toString().replace(/\`/g, '`'));
+                output('broken', e.toStringEx().replace(/\`/g, '`'));
             } else {
                 output('errored', e.stack || e.message || e);
             }