Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 2 spaces intend and single quote #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dennym
Copy link
Contributor

@dennym dennym commented Sep 21, 2015

Maybe rubocop should be used and also required by CI for green to have some nice unified styling. And not some random patched worked code base.

@ryanstout
Copy link
Member

@dennym My plan is to integrate auto-running of rubocop here in a few. I'm going to wait until after I get the sql stuff done so I don't have to deal with related merge conflicts until I have everything back on master.

@dennym
Copy link
Contributor Author

dennym commented Sep 22, 2015

Could be pretty pain to get the current codebase clean first :) Just got up yesterday and checked all new notifications in github and saw this painful 2 tabs code. Had to change it.

@alexandred
Copy link
Contributor

@dennym that's my code, sorry :) I come from an obscure ruby background where 4 space tabs were the standard in the codebase and I've continued this bad habit for 10 years now :) I've switched my sublime's tab settings to 2 spaces so it shouldn't happen in future PRs from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants