Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lintian hardening info messages #160

Merged
merged 1 commit into from
May 29, 2024

Conversation

narc-Ontakac2
Copy link
Collaborator

@narc-Ontakac2 narc-Ontakac2 commented May 23, 2024

I am unsure if the removal of -fno-stack-protector from CFLAGS has a negative impact.

This will probably not become a release, I just bumped the version to maintain the changelog.

@r00t-
Copy link
Collaborator

r00t- commented May 25, 2024

I am unsure if the removal of -fno-stack-protector from CFLAGS has a negative impact.

checked the history, this ticket lead to that code: dailab#3
i can't tell if this is important, nor understand the details, but it does not look like it was a good solution to anything.
this seems to explain a better fix, in case one is still needed: sauliusg/starta@e17e60f#commitcomment-19858411

LGTM.

@narc-Ontakac2
Copy link
Collaborator Author

But it looks like this would cause compile issues only, which it does not.

@narc-Ontakac2 narc-Ontakac2 merged commit c166372 into volkszaehler:master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants