[transport] generate log message on crc error #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mbehr1
approved these changes
Feb 14, 2023
| goto error; | ||
| *msg->crc != sml_crc16kermit_calculate(&(buf->buffer[msg_start]), len) | ||
| ){ | ||
| fprintf(stderr, "libsml: sml_message_parse(): crc mismatch, dropping message\n"); |
There was a problem hiding this comment.
the len of the message might be useful for debugging
There was a problem hiding this comment.
a hexdump would be even more useful, but we actually shouldn't be writing to stderr at all... :\
|
thanks. i don't think it makes much sense to add much more diagnostics until we have a better way of reporting/logging errors. but this is an improvement for now, and i think #103 already covers the topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my version of #109