Fix vmware layer so that files without a vmss or vmsn are still constructed with the warning is shown #1352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
User Super_Snorlax on slack raised an issue where a vmware sample failed to work with a
.vmem
extension but did with a.raw
extension.They've yet to report having tested this change but I suspect it will fix the issue.
I believe this return None incorrectly stops some samples for working. The warning says
may be required
but thereturn None
is meaning it will never be stacked.🦊