Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vmware layer so that files without a vmss or vmsn are still constructed with the warning is shown #1352

Conversation

eve-mem
Copy link
Contributor

@eve-mem eve-mem commented Nov 14, 2024

Hello 👋

User Super_Snorlax on slack raised an issue where a vmware sample failed to work with a .vmem extension but did with a .raw extension.

They've yet to report having tested this change but I suspect it will fix the issue.

I believe this return None incorrectly stops some samples for working. The warning says may be required but the return None is meaning it will never be stacked.

🦊

@eve-mem
Copy link
Contributor Author

eve-mem commented Nov 14, 2024

Actually the discussion on the where the warning was added #1016

It seems like the return None is okay. I'm changing this to draft until I hear from Super_Snorlax if this fixes the problem. (Or if I get my hands on a a flat vmware image type to test against)

@eve-mem eve-mem marked this pull request as draft November 14, 2024 21:32
@eve-mem eve-mem closed this Nov 15, 2024
@eve-mem eve-mem deleted the vmware_fix_missing_meta_files branch November 15, 2024 14:09
@eve-mem
Copy link
Contributor Author

eve-mem commented Nov 15, 2024

Super_Snorlax provided a sample and this did not help in the slightest. I'd got completely the wrong end of the stick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant