Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only one contents CLI option #20

Closed
wants to merge 1 commit into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 18, 2024

Fixes #19

Since this demo uses the xeus python kernel, and is focused on voici, we can just for the xeus mounting feature.

cc @martinRenou this is addressing the proposal mentioned in #19.

Additionally, we could link to the Voici / Xeus Python documentation for working with contents.

@martinRenou
Copy link
Member

Does this actually work? Will voici properly find the contents for filling the Voici tree page?

@jtpio
Copy link
Member Author

jtpio commented Jan 18, 2024

Good point!

Maybe the best way forward would then be to follow the discussion started in voila-dashboards/voici#104 (comment) and try to implement that in the xeus addon.

Converting to draft for now.

@jtpio jtpio marked this pull request as draft January 18, 2024 10:00
@martinRenou
Copy link
Member

Fixed by #22

@martinRenou
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the JupyterLite --contents CLI option?
2 participants