-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/ipfs refactor #1137
base: main
Are you sure you want to change the base?
feat/ipfs refactor #1137
Conversation
altergui
commented
Oct 9, 2023
- ipfs: add EnableLocalDiscovery option
- ipfs: refactor removing very old clutter and abstractions
our current way of initializing IPFS is absolutely convoluted, so i'm working towards a simplification (WIP) right now, this is a code snippet used by census3 for example
which doesn't look terrible, but: passing a new option (besides dataDir) is almost impossible i believe it would make much more sense to end up with something like this:
that would also allow me to add options through IPFSCfg, much more easily |
* data.Storage.Init now needs no args * move DataMockTest into its own package datamock * assert at compile time that datamock.DataMockTest and ipfs.Handler satisfy data.Storage * move fsrepo.IsInitialized check into startNode * remove ancient abstraction types.DataStore * fixup "ipfs: add EnableLocalDiscovery option": move field EnableLocalDiscovery into ipfs.Handler
3da1c4c
to
8ed7aa2
Compare
here's more progress but still there's a lot of duplication that i want to remove |
Pull Request Test Coverage Report for Build 6863543637
💛 - Coveralls |