Skip to content
This repository has been archived by the owner on Aug 23, 2024. It is now read-only.

B/bulk bugfixes #167

Merged
merged 6 commits into from
Feb 27, 2024
Merged

B/bulk bugfixes #167

merged 6 commits into from
Feb 27, 2024

Conversation

selankon
Copy link
Collaborator

Multiple bug fixing

@selankon
Update english translation
3c87002 
Closes #166
@selankon
Fix #165
bba64bf 
Move the links inside a component in order to rebuild it when language change
@selankon
Fix #165
a5b7fc2 
Move the links inside a component in order to rebuild it when language change
@selankon
Fix #160
8485488 
Add InvalidElection badge
@selankon selankon requested a review from elboletaire January 15, 2024 10:18
@selankon selankon requested a review from emmdim January 23, 2024 15:47
elboletaire
elboletaire suggested changes Jan 23, 2024
View reviewed changes
i18n/locales/ca.json Outdated Show resolved Hide resolved
i18n/locales/es.json Outdated Show resolved Hide resolved
emmdim
emmdim reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@emmdim emmdim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a series of warning during the build.
Could please you eliminate the ones related to
@typescript-eslint/no-unused-vars
and react-hooks/exhaustive-deps @selankon ?
You can find them by doing a build locally as well

components/pages/app/footer.tsx Outdated Show resolved Hide resolved
components/pages/app/footer.tsx Outdated Show resolved Hide resolved
@selankon
Minor bugfixes
beb440e 
Fix typos, delete commented and correct links
@selankon
Fix lint warnings
87b5eb5
@selankon
Copy link
Collaborator Author

There are a series of warning during the build. Could please you eliminate the ones related to @typescript-eslint/no-unused-vars and react-hooks/exhaustive-deps @selankon ? You can find them by doing a build locally as well

This is done on 87b5eb5

@selankon
Copy link
Collaborator Author

This is ready for merge @emmdim

@selankon selankon merged commit bf47cbf into master Feb 27, 2024
4 checks passed
@selankon selankon deleted the b/bulk-bugfixes branch February 27, 2024 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpaulet jpaulet jpaulet left review comments

@emmdim emmdim emmdim left review comments

@elboletaire elboletaire elboletaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@selankon @elboletaire @emmdim @jpaulet