Corrections in certificates docs #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjun
reviewed
Sep 17, 2019
| @@ -128,17 +126,16 @@ For information about how to automatically generate a client certificate during | |||
|
|
|||
| ### Custom Client Certificate <a id="clientcert"></a> | |||
|
|
|||
| For the VCH to trust the CA that you use to sign the client certificate, the CA must include the following elements: | |||
| For the VCH to trust the CA that you use to sign the client certificate, the client certificate must include the following elements: | |||
There was a problem hiding this comment.
Please remove the first part and only keep "The client certificate must include the following elements:"
wjun
reviewed
Sep 17, 2019
| @@ -128,17 +126,16 @@ For information about how to automatically generate a client certificate during | |||
|
|
|||
| ### Custom Client Certificate <a id="clientcert"></a> | |||
|
|
|||
| For the VCH to trust the CA that you use to sign the client certificate, the CA must include the following elements: | |||
| For the VCH to trust the CA that you use to sign the client certificate, the client certificate must include the following elements: | |||
|
|
|||
| - The name or address of the system from which the Docker client accesses the server in the subject or subject alternative name. This can be an FQDN or a wildcard domain. | |||
There was a problem hiding this comment.
Remove this requirement that actually made the user confusion in the bug.
wjun
approved these changes
Sep 17, 2019
|
Thanks @wjun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2460
@wjun, does this cover everything from internal bug 2339700? Thanks!