Skip to content

Commit

Permalink
Add error and logging UX improvements for PSC (#761)
Browse files Browse the repository at this point in the history
  • Loading branch information
Anchal Agrawal authored Sep 7, 2017
1 parent 39dd0dc commit ce9fca6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion installer/fileserver/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ func startInitializationServices() string {

if err := registerWithPSC(ctx); err != nil {
log.Debug(errors.ErrorStack(err))
errorMsg = append(errorMsg, "Failed to register with PSC: %s", err.Error())
errorMsg = append(errorMsg, "Failed to register with PSC. Please check the vSphere user domain PSC settings and try again")
}

if len(errorMsg) == 0 {
Expand Down
2 changes: 1 addition & 1 deletion installer/fileserver/tasks.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func registerWithPSC(ctx context.Context) error {
// This runs the PSC tool's register command.
cmd := exec.Command(cmdName, cmdArgs...)
if output, err := cmd.CombinedOutput(); err != nil {
log.Infof("Error running PSC register command: %s", string(output))
log.Infof("Error running PSC register command for %s: %s", client, string(output))
return err
}
log.Infof("Successfully registered %s with PSC", client)
Expand Down

0 comments on commit ce9fca6

Please sign in to comment.