Use custom version of timely, improve rule formatting. #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`struct Program` generated by the compiler contains strings representing complete rules and their fragments in every node, used to generate human-readable profiles. Since this struct is generated after the type inference step, the rules contain numerous type annotations that bloat their size. This causes problems in two ways. First, all these type annotations make it hard to read the profile. Second, for very large projects they can significantly blow up the memory footprint of the program. This patch addresses both issues by stripping type annotations from rules before pretty-printing them.
Switch to using a custom version of timely and differential from:
```
differential-dataflow = { git = "https://github.com/ddlog-dev/differential-dataflow", branch = "ddlog-1" }
timely = { git = "https://github.com/ddlog-dev/timely-dataflow", branch = "ddlog-1" }
```
So far, the only customization on top of vanilla timely 0.11.1 is
modified `Message::default_size` constant. Original value: 1024, new
value: 128. The large default buffer size can waste a lot of memory on
static allocations in very large dataflow graphs. The new value reduces
the waste without impacting the performance too much (based on limited
benchmarking).
|
So what's in the custom forks? |
Just this: ddlog-dev/timely-dataflow@9e6928e |
mihaibudiu
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.