Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create object and commands to assign global permission (#473) #638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

win32asm
Copy link

vCenter UI provides functionality to set 'global permissions' for accounts: https://docs.vmware.com/en/VMware-vSphere/8.0/vsphere-security/GUID-C7702E31-1623-4189-89CB-E1136AA27972.html However, there is no automation for this operation.

The approach taken is to communicate with vCenter MOB and execute the request modelling browser operation.

@vmwclabot
Copy link
Member

@win32asm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@et1975
Copy link

et1975 commented Nov 14, 2024

Closes #473

@win32asm win32asm force-pushed the global_permissions branch 2 times, most recently from 17c00ef to 212d2af Compare November 15, 2024 02:42
@win32asm
Copy link
Author

@et1975 does it make sense to change prefix of cmdlet object names from *-VcenterServer* to, say, *-VCMOB* ?
like, Connect-VCMOBServer, Disconnect-VCMOBServer, Set-VCMOBGlobalPermission

@win32asm win32asm force-pushed the global_permissions branch 3 times, most recently from 324f2ef to 49aa62d Compare November 15, 2024 11:28
Copy link

@et1975 et1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the maintainers can chime in, but it looks good to me.

Modules/VMware.vSphere.SsoAdmin/MobConnect.ps1 Outdated Show resolved Hide resolved
vCenter UI provides functionality to set 'global permissions' for accounts:
https://docs.vmware.com/en/VMware-vSphere/8.0/vsphere-security/GUID-C7702E31-1623-4189-89CB-E1136AA27972.html
However, there is no automation for this operation.

The approach taken is to communicate with vCenter MOB and execute the
request modelling browser operation.

Signed-off-by: Vladimir Bespalov <[email protected]>
@dmilov
Copy link
Contributor

dmilov commented Nov 20, 2024

@lamw I see code borrowed from your repo in this PR. Can you take a look at the PR from the perspective of code VMware OSS policies? Thanks!

@lamw
Copy link
Contributor

lamw commented Nov 25, 2024

LGTM

@win32asm
Copy link
Author

@dmilov anything else we need to do to have the code included?
Thanks!

@dmilov
Copy link
Contributor

dmilov commented Nov 29, 2024

@dmilov anything else we need to do to have the code included? Thanks!

I don't think so. You can go ahead merge it

@win32asm
Copy link
Author

win32asm commented Nov 29, 2024

@dmilov Wish I had write access to the repo. 8-\
Anyone I could ping to merge PR?

@dmilov
Copy link
Contributor

dmilov commented Dec 2, 2024

@dmilov Wish I had write access to the repo. 8-\ Anyone I could ping to merge PR?

@lyuboasenov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants