Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check TLS bundle before dialing for performance reasons, and add godoc to clarify intent #2065

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

joshuatcasey
Copy link
Member

Check TLS bundle before dialing for performance reasons, and add godoc to clarify intent

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for pinniped-dev canceled.

Name Link
🔨 Latest commit 629f89d
🔍 Latest deploy log https://app.netlify.com/sites/pinniped-dev/deploys/66fda501fc3c1c0008e51368

@joshuatcasey joshuatcasey force-pushed the jtc/dont-leak-goroutines-during-ldap-dial branch from 2cf343b to 629f89d Compare October 2, 2024 19:54
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 31.16%. Comparing base (bb00587) to head (629f89d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/upstreamldap/upstreamldap.go 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
- Coverage   31.17%   31.16%   -0.01%     
==========================================
  Files         369      369              
  Lines       60999    61002       +3     
==========================================
- Hits        19017    19013       -4     
- Misses      41457    41464       +7     
  Partials      525      525              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr cfryanr merged commit d4bb12e into main Oct 8, 2024
36 of 47 checks passed
@cfryanr cfryanr deleted the jtc/dont-leak-goroutines-during-ldap-dial branch October 8, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants