Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check more resources realized status when creating subnet #921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Nov 22, 2024

Subnet includes child resources which also need checking realized status.
Add RealizedLogicalPort, RealizedLogicalRouterPort checking

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.40%. Comparing base (a2702f2) to head (5259e2b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nsx/services/subnet/subnet.go 50.00% 0 Missing and 1 partial ⚠️
pkg/nsx/services/vpc/vpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   73.26%   73.40%   +0.13%     
==========================================
  Files         109      109              
  Lines       15095    15253     +158     
==========================================
+ Hits        11059    11196     +137     
- Misses       3284     3306      +22     
+ Partials      752      751       -1     
Flag Coverage Δ
unit-tests 73.40% <81.81%> (+0.13%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/realizestate/realize_state.go 95.00% <100.00%> (+3.33%) ⬆️
pkg/nsx/services/subnetport/subnetport.go 80.83% <100.00%> (ø)
pkg/nsx/services/subnet/subnet.go 66.66% <50.00%> (+1.00%) ⬆️
pkg/nsx/services/vpc/vpc.go 56.08% <0.00%> (ø)

... and 6 files with indirect coverage changes

@TaoZou1 TaoZou1 force-pushed the subnetrealize branch 3 times, most recently from 6e4d6ed to 3705969 Compare November 22, 2024 09:18
@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Nov 25, 2024

/e2e

Subnet includes child resources which also need checking realized status.
Check subnet for all child resources
Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants