[velero] fix: render schedule annotations only if present in values #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Xu <[email protected]>
|
LGTM |
@jenting I just resolved the conflicts of Chart.yaml, could you help review again? Thanks! |
jenting
approved these changes
Sep 4, 2024
|
@ywk253100 @qiuming-best do you know if you'll have time to review this PR? very appreciate. |
ywk253100
approved these changes
Sep 5, 2024
wyattfry
pushed a commit
to wyattfry/helm-charts
that referenced
this pull request
Oct 24, 2024
…nzu#616) Signed-off-by: Max Xu <[email protected]> Signed-off-by: Wyatt Fry <[email protected]>
ywk253100
pushed a commit
that referenced
this pull request
Oct 30, 2024
* fix: render schedule annotations only if present in values (#616) Signed-off-by: Max Xu <[email protected]> Signed-off-by: Wyatt Fry <[email protected]> * Add Kubernetes-recommended Version Label Signed-off-by: Wyatt Fry <[email protected]> * Bump chart version Signed-off-by: Wyatt Fry <[email protected]> --------- Signed-off-by: Max Xu <[email protected]> Signed-off-by: Wyatt Fry <[email protected]> Co-authored-by: Max Xu <[email protected]> Co-authored-by: Wyatt Fry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
The
charts/velero/templates/schedule.yamlwill always render the annotations section even if there is no values defined, which will bring following meaningless result:kind: Schedule metadata: + annotations: nullAnd many tools like argo-cd will treat it as diff, so we should only render annotations only if present in values.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero])