-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc][LoRA] Move the implementation of lora bias to punica.py #10829
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
@DarkLight1337 If you have bandwith, plz look at this PR, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the code cleanup!
Please fix the lint errors. |
Signed-off-by: Jee Jee Li <[email protected]>
Motivation
Moving the lora bias calculation code from layers.py and fully_sharded_layers.py to punica.py.
The purpose is to consolidate all lora-related calculations in punica.py, making it easier to support lora on different hardware platforms in the future.
cc @SanjuCSudhakaran