Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc][LoRA] Move the implementation of lora bias to punica.py #10829

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Dec 2, 2024

Motivation

Moving the lora bias calculation code from layers.py and fully_sharded_layers.py to punica.py.

The purpose is to consolidate all lora-related calculations in punica.py, making it easier to support lora on different hardware platforms in the future.

cc @SanjuCSudhakaran

Copy link

github-actions bot commented Dec 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee jeejeelee changed the title Move lora bias [Misc][LoRA] Move the implementation of lora bias to punica.py Dec 2, 2024
@jeejeelee jeejeelee marked this pull request as draft December 2, 2024 10:47
@jeejeelee jeejeelee marked this pull request as ready for review December 2, 2024 15:52
@jeejeelee
Copy link
Collaborator Author

@DarkLight1337 If you have bandwith, plz look at this PR, thanks.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code cleanup!

@DarkLight1337
Copy link
Member

Please fix the lint errors.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 2, 2024
Signed-off-by: Jee Jee Li <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 2, 2024 16:06
@DarkLight1337 DarkLight1337 merged commit b45f0d7 into vllm-project:main Dec 2, 2024
49 checks passed
@jeejeelee jeejeelee deleted the move-lora-bias branch December 2, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants