Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves some LC13 essential structures to their own files [DONE] #2591

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

InsightfulParasite
Copy link
Collaborator

About The Pull Request

Sloppily moves two lc13 structures that shouldnt cause conflicts to their own folder in ModularTegustation. Created a lc13_computer folder for our various computers. I tried to keep this small to avoid conflicts and atomize changes. Ill likely do small movements of sprites from random files to our dmi's.

Testing hasnt shown and errors caused by this move.

Why It's Good For The Game

Assists with keeping LC13 code in a more recognizable spot rather than scattered about.

Changelog

🆑
refractor: move regenerator.dm & _adventure_console folder into lc13_obj refractor: move into abnormality computer consoles into their own lc13_computer folder
/:cl:

@InsightfulParasite InsightfulParasite added the Refactor Changes how code is written without changing how it functions. label Dec 6, 2024
@Gboster-0
Copy link
Collaborator

i like this PR, tho why not move the LC computers into ModularTegustation

@Gboster-0 Gboster-0 added the Code improvement Code is now easier to copy paste. label Dec 6, 2024
@InsightfulParasite
Copy link
Collaborator Author

i like this PR, tho why not move the LC computers into ModularTegustation

I wasnt sure if it was too much of a move for a small PR.
I can move LC computers to Tegu if need be.

@InsightfulParasite InsightfulParasite changed the title Moves some LC13 essential structures to their own files Moves some LC13 essential structures to their own files [DONE] Dec 8, 2024
@Kitsunemitsu
Copy link
Contributor

i like this PR, tho why not move the LC computers into ModularTegustation

I wasnt sure if it was too much of a move for a small PR. I can move LC computers to Tegu if need be.

Go for it

@InsightfulParasite InsightfulParasite force-pushed the organization-1.0 branch 4 times, most recently from d4f6131 to 11d9233 Compare December 9, 2024 02:48
@InsightfulParasite
Copy link
Collaborator Author

i like this PR, tho why not move the LC computers into ModularTegustation

I wasnt sure if it was too much of a move for a small PR. I can move LC computers to Tegu if need be.

Go for it

dONE!

## About The Pull Request
Sloppily moves two lc13 structures that shouldnt cause conflicts to their own folder in ModularTegustation.
Created a lc13_computer folder for our various computers.
I tried to keep this small to avoid conflicts and atomize changes. Ill likely do small movements of sprites from random files to our dmi's.

## Why It's Good For The Game
Assists with keeping LC13 code in a more recognizable spot rather than scattered about.
<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. -->

## Changelog
:cl:
refractor: move regenerator.dm &  _adventure_console folder into lc13_obj
refractor: move into abnormality computer consoles into their own lc13_computer folder
/:cl:
@InsightfulParasite
Copy link
Collaborator Author

#1609

Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moving files, approved. Looks good to me.

@Kitsunemitsu Kitsunemitsu merged commit 1464348 into vlggms:master Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste. Refactor Changes how code is written without changing how it functions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants