Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves most duplicate alt refinery checks to the parent and some cleanup #2045

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

Gboster-0
Copy link
Collaborator

@Gboster-0 Gboster-0 commented Apr 9, 2024

About The Pull Request

Moves the following to the alt refineries parent:

  • extraction officer check
  • PE check (disabled by default)
  • Removing PE

Replaces timed refineries 5 lines of code with 2, using for(var/i in 1 to 5) instead of copy-pasting new() 5 times

Makes the machines tell you that you need to input in an item if they need it both on examine and trying to click them with one.
Also causes the refineries to call attack_hand() if you touch them with an item whilst they do not need any items

Also added mapload argument to the refineries initialize, because im quite sure its supposed to be there

Why It's Good For The Game

Bit less copy-paste

Changelog

🆑
qol: PE refineries will now tell you if you need to insert in an item
code: Moved some code around in alt refineries
/:cl:

@Kitsunemitsu Kitsunemitsu added the Code improvement Code is now easier to copy paste. label Apr 9, 2024
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. A quick refactor that I should have done but it escaped my notice.

@Kitsunemitsu Kitsunemitsu merged commit 6aede79 into vlggms:master Apr 12, 2024
11 checks passed
@Gboster-0 Gboster-0 deleted the refinery-cleanup branch April 12, 2024 02:56
vampirebat74 pushed a commit to vampirebat74/lobotomy-corp13 that referenced this pull request May 10, 2024
…up (vlggms#2045)

* initial commit

* removes forced parent calls, machines talk about items

* minor qol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants