replaces ". = ..()" parent calls with "return ..()" where applicable without changing surrounding code. Forces some abnormality procs to be called by children #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsightfulParasite
added
Code improvement
LanceSmites328
previously approved these changes
Oct 15, 2023
There was a problem hiding this comment.
I'll say a lot of the changes from . = ..() to return ..() aren't necessary for functionality, as . is the default return value of the proc (among other things that are out of scope), so doing . = ..() runs the original parent proc and sets the current return value to that. However this is an overall improvement in code legibility.
EgorDinamit
reviewed
Oct 15, 2023
code/modules/mob/living/simple_animal/abnormality/he/you_strong.dm
Outdated
Show resolved
Hide resolved
|
I suspect that this could cause some bugs, be careful with merging it. |
EgorDinamit
approved these changes
Oct 16, 2023
vampirebat74
pushed a commit
to vampirebat74/lobotomy-corp13
that referenced
this pull request
May 10, 2024
…without changing surrounding code. Forces some abnormality procs to be called by children (vlggms#1527) * boop * boop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
changes ". = ..()" calls for "return ..()" where it can be changed without affecting surrounding code
forces initialize(), destroy(), life(), WorkComplete() and GiftUser() to be called by an abnormality if they implement custom code
i would have also forced people to call FearEffect() but meat lantern requires to not call parent to be stealthy
Why It's Good For The
GameCodebasejuuuuuuuust in case contributors forget to call . = ..() on some procs and have to spend time diagonising the issue, this makes it a lil bit faster to show up
Changelog
🆑
code: some . = ..() calls were replaced with return ..()
code: abnormalities are now required to call certain proc's
/:cl: