-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Bee and Lady Facing the wall Icon and Reward Tweaks #1520
Merged
EgorDinamit
merged 1 commit into
vlggms:master
from
InsightfulParasite:Icon-Change-Edits
Nov 19, 2023
Merged
General Bee and Lady Facing the wall Icon and Reward Tweaks #1520
EgorDinamit
merged 1 commit into
vlggms:master
from
InsightfulParasite:Icon-Change-Edits
Nov 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsightfulParasite
added
Code improvement
Code is now easier to copy paste.
Tweak
A small change/addition to already existing systems.
labels
Oct 13, 2023
InsightfulParasite
force-pushed
the
Icon-Change-Edits
branch
from
October 14, 2023 19:58
f85cda3
to
438ec9d
Compare
Kitsunemitsu
previously approved these changes
Oct 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Nevermind my approval doesn't mean anything |
InsightfulParasite
force-pushed
the
Icon-Change-Edits
branch
from
October 17, 2023 22:47
438ec9d
to
f600957
Compare
Kitsunemitsu
previously approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Good to go.
InsightfulParasite
force-pushed
the
Icon-Change-Edits
branch
from
November 5, 2023 06:34
f600957
to
1e3e03e
Compare
InsightfulParasite
force-pushed
the
Icon-Change-Edits
branch
from
November 13, 2023 05:07
1e3e03e
to
26f74e3
Compare
EgorDinamit
reviewed
Nov 17, 2023
code/modules/mob/living/simple_animal/abnormality/_abnormality.dm
Outdated
Show resolved
Hide resolved
EgorDinamit
reviewed
Nov 17, 2023
InsightfulParasite
force-pushed
the
Icon-Change-Edits
branch
from
November 18, 2023 23:19
26f74e3
to
844732d
Compare
InsightfulParasite
force-pushed
the
Icon-Change-Edits
branch
from
November 18, 2023 23:20
844732d
to
2a8fa4a
Compare
EgorDinamit
approved these changes
Nov 19, 2023
vampirebat74
pushed a commit
to vampirebat74/lobotomy-corp13
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code improvement
Code is now easier to copy paste.
Tweak
A small change/addition to already existing systems.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
General Bee will now show her breach animation on escape.
General Bee's loot drop conditions are now that she must be breached.
Lady Facing the wall has her animation turned into a flick()
Why It's Good For The Game
I feel like this is a more simple way of doing it since flick is mostly for temporary animations. The loot spawn conditions is also good since we had a issue a LONG long time ago with general bee dropping her loot in containment.
Changelog
🆑
tweak: General B breach animation and lootspawn conditions
tweak: lady facing the wall now uses flick() for her scare animation
/:cl: