Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a lance to Road home #1516

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Adds a lance to Road home #1516

merged 9 commits into from
Oct 12, 2023

Conversation

CrabbytheCrab
Copy link
Contributor

@CrabbytheCrab CrabbytheCrab commented Oct 11, 2023

About The Pull Request

Adds Brick Road a white damage lance for road home

It does 50 white with a 4 attack speed to really force you to use its lance part but still being alright. . When you charge with it you leave a brick road that lasts for 30 seconds that slows down abnormalities by 25%.

Why It's Good For The Game

Giving road home a second weapon would make her more viable

Changelog

🆑
add: Adds brick road
imageadd: added charge states to Homing Instinct as a placeholder
/:cl:

Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inappropriate.
Add in a new weapon for Road Home.

@CrabbytheCrab
Copy link
Contributor Author

I might but at the same time homing instinct in its current version isn't that good outside of having a p corp rep

@CrabbytheCrab CrabbytheCrab changed the title Turns Homing Instinct into a lance Adds a lance to Road home Oct 11, 2023
@CrabbytheCrab
Copy link
Contributor Author

did it

@CrabbytheCrab
Copy link
Contributor Author

can this get a second review now thats it is its own weapon @Kitsunemitsu ?

Kitsunemitsu
Kitsunemitsu previously approved these changes Oct 12, 2023
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

code/game/objects/items/ego_weapons/he.dm Outdated Show resolved Hide resolved
code/game/objects/items/ego_weapons/he.dm Outdated Show resolved Hide resolved
code/game/objects/items/ego_weapons/he.dm Outdated Show resolved Hide resolved
@LanceSmites328 LanceSmites328 merged commit ef0bd15 into vlggms:master Oct 12, 2023
6 checks passed
@TheBronJameOffical
Copy link
Collaborator

The lowered right inhand iconstate name has a semicolon in it making it not show up in game.

@Kitsunemitsu Kitsunemitsu added the Tweak A small change/addition to already existing systems. label Oct 14, 2023
vampirebat74 pushed a commit to vampirebat74/lobotomy-corp13 that referenced this pull request May 10, 2024
* s

* j

* d

* Update he.dm

* Update he.dm

* Update he.dm

* k

* Update he.dm

* Update he.dm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants