Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Charge Weapons #1511

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Fixes Charge Weapons #1511

merged 1 commit into from
Oct 15, 2023

Conversation

scionalu
Copy link
Contributor

@scionalu scionalu commented Oct 9, 2023

About The Pull Request

Charge weapons were being used by low leveled users because returning false or breaking ..() does nothing to prevent the rest of the code from running
So I added several extra checks if the parent returns FALSE

Why It's Good For The Game

no more silly infinite charges

Changelog

🆑
fix: fixed charge weapons
/:cl:

@InsightfulParasite InsightfulParasite added the Fix There was a bug, and we fixed it! label Oct 9, 2023
Copy link
Contributor

@LanceSmites328 LanceSmites328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, while this would fix the issue, it's not the best way to do it by a long shot and will in all likelihood result in double messages. What should be getting used is

. = ..()
if(!.)
	return

This runs the parent (which it already does) and stores that value as the proc's value. If it's FALSE, like what returns from EGO_CHECK failing, then it'll be FALSE and then stop running, which is what we want

@LanceSmites328 LanceSmites328 merged commit 0f5e459 into vlggms:master Oct 15, 2023
6 checks passed
vampirebat74 pushed a commit to vampirebat74/lobotomy-corp13 that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix There was a bug, and we fixed it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants