Abnormality Portrait Refactor (#2411)

* Image Optimization

* Update lobotomy-corp13.dme

* Even Cooler

* Bestest

code/__HELPERS/abnormalities.dm

@@ -78,3 +78,17 @@
 			return "High"
 
 	return "Unknown ([rate])"
+
+/*
+	Try to keep images 256px on at least one side to keep file sizes small - Coxswain
+*/
+GLOBAL_LIST_EMPTY(abnormality_portraits)
+#define PORTRAIT_PATH "icons/UI_Icons/abnormality_portraits/"
+/proc/create_portrait_paths()
+	. = list()
+	for(var/file in flist(PORTRAIT_PATH))
+		if(copytext("[file]", -1) == "/")
+			continue
+		. += file("[PORTRAIT_PATH][file]")
+	GLOB.abnormality_portraits = .
+#undef PORTRAIT_PATH

code/game/gamemodes/management/management.dm

@@ -18,6 +18,10 @@
 		)
 	var/list/gamemode_abnos = list(ZAYIN_LEVEL = list(), TETH_LEVEL = list(), HE_LEVEL = list(), WAW_LEVEL = list(), ALEPH_LEVEL = list())
 
+/datum/game_mode/management/pre_setup()
+	create_portrait_paths()
+	return ..()
+
 /datum/game_mode/management/post_setup()
 	SSpersistence.LoadAbnoPicks() // Persistence system WILL have loaded at this point. Functionally means 0 abnos are slotted/loaded before the game itself is ready.
 	var/list/all_abnos = SSpersistence.abno_rates

code/game/machinery/computer/abnormality_work.dm

@@ -93,8 +93,7 @@
 	dat += "<br>"
 
 	//Abnormality portraits
-	var/list/paths = get_portrait_path()
-	for(var/pahs in paths)
+	for(var/pahs in GLOB.abnormality_portraits)
 		user << browse_rsc(pahs)
 	dat += {"<div style="float:right; width: 60%;">
 	<img src='[datum_reference.GetPortrait()].png' class="fit-picture" width="192" height="192">

lobotomy-corp13.dme

@@ -958,7 +958,6 @@
 #include "code\game\machinery\computer\abnormality_auxiliary.dm"
 #include "code\game\machinery\computer\abnormality_ego.dm"
 #include "code\game\machinery\computer\abnormality_logs.dm"
-#include "code\game\machinery\computer\abnormality_portraits.dm"
 #include "code\game\machinery\computer\abnormality_queue.dm"
 #include "code\game\machinery\computer\abnormality_work.dm"
 #include "code\game\machinery\computer\aifixer.dm"