cgen: fix codegen for return on last statement of return IfExpr

[felipensp]

Fix #23550

[huly-for-github]

Connected to Huly®: V_0.6-21979

[JalonSolov]

So you're just making sure the return is output, rather than warning/error?

[felipensp]

So you're just making sure the return is output, rather than warning/error?

Yes. Just like we do in return match foo { a { return expr } else { ... } }

[JalonSolov]

I think that's a mistake as well. A return inside a return makes no sense.

[spytheman]

I think that's a mistake as well. A return inside a return makes no sense.

It does make sense a bit, since in the if cond { expr1 } else { expr2 } form,
expr1 and expr2 can be compound expression lists, i.e. they may have statements (including logic ones, and early returns).

I do think that in many cases, such long if expressions, can become convoluted, and allow for bugs, but the language does allow them :-| .

[spytheman]

In any case, unless they are banned, V should not produce garbage, that fails at runtime (the branch with the return was executed in the issue, but the output was not, what was returned, but empty values).

[spytheman]

Excellent work.