Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markused: cleanup as_cast handling #23538

Merged
merged 2 commits into from
Jan 21, 2025
Merged

markused: cleanup as_cast handling #23538

merged 2 commits into from
Jan 21, 2025

Conversation

felipensp
Copy link
Member

Cleanup

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: V_0.6-21966

@spytheman
Copy link
Member

As casting works fine.
I do not see what should be cleaned up about it.

@felipensp
Copy link
Member Author

As casting works fine. I do not see what should be cleaned up about it.

All this logic with map to just ensure that new_array... must be created is not needed.

@spytheman
Copy link
Member

It is - see the failing CI.
Besides, all that logic is triggered only for ast.AsCast expressions, which are relatively rare.

@felipensp
Copy link
Member Author

It is - see the failing CI. Besides, all that logic is triggered only for ast.AsCast expressions, which are relatively rare.

Just need a fix.

@felipensp felipensp marked this pull request as ready for review January 21, 2025 01:58
spytheman
spytheman approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit ea5f25e into vlang:master Jan 21, 2025
72 checks passed
@felipensp felipensp deleted the remove_unused_code branch January 21, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipensp @spytheman