Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgen: cleanup spawn_and_go and fix #23390 #23392

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Jan 6, 2025

@felipensp felipensp marked this pull request as ready for review January 6, 2025 12:41
@felipensp felipensp changed the title cgen: cleanup spawn_and_go cgen: cleanup spawn_and_go and fix #23390 Jan 6, 2025
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@felipensp
Copy link
Member Author

Excellent work.

It is failing on musl, should add an ignore clause there?

@spytheman
Copy link
Member

No, please leave it as it is for now.
I would like to reproduce it locally first, to see the actual difference.

@spytheman
Copy link
Member

Locally, after installing diffutils:

vlib/v/slow_tests/inout/thread_uninitialized_err.vv FAIL
------------------------------------------------------------------- difference: -----------------------------------------------------------------
--- /tmp/v/257500873191573/base 2025-01-07 11:54:50.125835442 +0000
+++ /tmp/v/257500873191573/target       2025-01-07 11:54:50.125835442 +0000
@@ -1,2 +1,2 @@
 ================ V panic ================
-V panic: unable to join thread
+0x7ff94e6d3404: at ???: RUNTIME ERROR: invalid memory access
-------------------------------------------------------------------------------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cgen error when trying to thread.wait() on an unset thread field of struct
2 participants