Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: fix formating a file in an oscillating manner (fix #22223, fix #22026) #22232

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

yuyi98
Copy link
Member

@yuyi98 yuyi98 commented Sep 16, 2024

This PR fix formating a file in an oscillating manner (fix #22223, fix #22026).

  • Fix formating a file in an oscillating manner.
  • Fmt all the related files.

edit by spytheman: removed the long example from the description; it can be seen in the Files tab.

@yuyi98
Copy link
Member Author

yuyi98 commented Sep 16, 2024

Hmm... I'd disagree with

	aa = 1 // aa
	bbb // bbb

I think it should be

	aa = 1 // aa
	bbb    // bbb

Even though there is no initializer on bbb, it is still next to aa with no blank lines or comments between them.

spytheman added a commit to vlang/vsl that referenced this pull request Sep 17, 2024
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit acf6b34 into vlang:master Sep 17, 2024
79 checks passed
@yuyi98 yuyi98 deleted the fix_fmt_struct_init branch September 17, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants