net.mbedtls: add stores client ip and shutdown on handshake failure #22184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stores clients ip in the SSLConn struct. Calls conn.shutdown() in event of handshake failure to avoid hanging CLOSE_WAIT sockets.
spytheman
approved these changes
Sep 9, 2024
spytheman
reviewed
Sep 9, 2024
Comment on lines
+269
to
+271
| if iplen == 4 { | ||
| conn.ip = '${ip[0]}.${ip[1]}.${ip[2]}.${ip[3]}' | ||
| } |
There was a problem hiding this comment.
What happens for ipv6 addresses?
There was a problem hiding this comment.
not sure, should prob. be joined like y:y:y:y:y:y:y:y i'll fix when i get to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores clients ip in the SSLConn struct.
Calls conn.shutdown() in event of handshake failure to avoid hanging CLOSE_WAIT sockets.