feat: source.fixAll.swiftlint #81 (#95)

README.md

@@ -53,11 +53,12 @@ let package = Package(
 
 ## Commands
 
-| Short Title               | Command                   |
-| ------------------------- | ------------------------- |
-| SwiftLint: Lint workspace | `swiftlint.lintWorkspace` |
-| SwiftLint: Fix workspace  | `swiftlint.fixWorkspace`  |
-| SwiftLint: Fix document   | `swiftlint.fixDocument`   |
+| Short Title                     | Command                   |
+| ------------------------------- | ------------------------- |
+| SwiftLint: Lint workspace       | `swiftlint.lintWorkspace` |
+| SwiftLint: Fix workspace        | `swiftlint.fixWorkspace`  |
+| SwiftLint: Fix document         | `swiftlint.fixDocument`   |
+| SwiftLint: Fix all known issues | `source.fixAll.swiftlint` |
 
 To automatically fix all issues within a document on save, add the following to your `.vscode/settings.json`:
 

package.json

@@ -120,6 +120,11 @@
         "title": "SwiftLint: Fix all autocorrect issues in document",
         "command": "swiftlint.fixDocument",
         "shortTitle": "SwiftLint: Fix document"
+      },
+      {
+        "title": "SwiftLint: Fix all known autocorrect issues",
+        "command": "source.fixAll.swiftlint",
+        "shortTitle": "SwiftLint: Fix all known issues"
       }
     ]
   },

src/Current.ts

@@ -20,6 +20,7 @@ export interface Current {
     lintWorkspace: string;
     fixWorkspace: string;
     fixDocument: string;
+    fixAll: string;
   };
   config: {
     isEnabled(): boolean;
@@ -80,6 +81,7 @@ export function prodEnvironment(): Current {
       lintWorkspace: "swiftlint.lintWorkspace",
       fixWorkspace: "swiftlint.fixWorkspace",
       fixDocument: "swiftlint.fixDocument",
+      fixAll: "source.fixAll.swiftlint",
     },
     config: {
       affectsConfiguration: (changeEvent: vscode.ConfigurationChangeEvent) =>

src/SwiftLintProvider.ts

@@ -65,32 +65,11 @@ export class SwiftLint {
       this.fixWorkspace().then(() => this.lintWorkspace());
     });
     commands.registerCommand(Current.commands.fixDocument, (...args) =>
-      setTimeout(() => performfixDocument(...args), 1)
+      setTimeout(() => this.performFixDocument(...args), 1)
+    );
+    commands.registerCommand(Current.commands.fixAll, () =>
+      setTimeout(() => this.fixAllKnownDiagnostics(), 1)
     );
-    const performfixDocument = async (...args: any[]) => {
-      let docs: TextDocument[];
-      if (args.length === 0 && window.activeTextEditor) {
-        docs = [window.activeTextEditor.document];
-      } else {
-        docs = [];
-        for (let arg of args) {
-          const textDocument = await workspace.openTextDocument(arg);
-          docs.push(textDocument);
-        }
-      }
-      for (const doc of docs) {
-        if (doc.isDirty) {
-          await doc.save();
-        }
-        await this.fixDocument(doc);
-        setTimeout(() => {
-          const updatedDoc = workspace.textDocuments.find(
-            (textDoc) => textDoc.uri === doc.uri
-          );
-          this.lintDocument(updatedDoc ?? doc);
-        }, 100);
-      }
-    };
 
     workspace.onDidChangeConfiguration((configChange) => {
       if (Current.config.affectsConfiguration(configChange)) {
@@ -125,6 +104,32 @@ export class SwiftLint {
     }
   }
 
+  private async performFixDocument(...args: any[]) {
+    let docs: TextDocument[];
+    if (args.length === 0 && window.activeTextEditor) {
+      docs = [window.activeTextEditor.document];
+    } else {
+      docs = [];
+      for (let arg of args) {
+        const textDocument = await workspace.openTextDocument(arg);
+        docs.push(textDocument);
+      }
+    }
+    const updates = docs.map(async (doc) => {
+      if (doc.isDirty) {
+        await doc.save();
+      }
+      await this.fixDocument(doc);
+      setTimeout(() => {
+        const updatedDoc = workspace.textDocuments.find(
+          (textDoc) => textDoc.uri === doc.uri
+        );
+        this.lintDocument(updatedDoc ?? doc);
+      }, 100);
+    });
+    return Promise.all(updates);
+  }
+
   public async fixDocument(document: TextDocument) {
     if (document.languageId !== "swift" || document.uri.scheme === "git") {
       return;
@@ -213,4 +218,15 @@ export class SwiftLint {
 
     await Promise.all(lintWorkspaces);
   }
+
+  public async fixAllKnownDiagnostics() {
+    const docs = new Set<Uri>();
+    this.diagnosticCollection.forEach((uri) => {
+      if (docs.has(uri)) {
+        return;
+      }
+      docs.add(uri);
+    });
+    return this.performFixDocument(...docs.values());
+  }
 }

src/lint.ts

@@ -53,7 +53,10 @@ export async function diagnosticsForDocument(request: {
     return [];
   }
 
-  if (!request.document.uri.fsPath || request.document.uri.fsPath.includes(".swiftinterface")) {
+  if (
+    !request.document.uri.fsPath ||
+    request.document.uri.fsPath.includes(".swiftinterface")
+  ) {
     return [];
   }
 
@@ -180,7 +183,7 @@ export async function diagnosticsForFolder(request: {
       ? []
       : await filterAsync(allFiles, (path) => config.includes(path))
     : request.parameters || [];
-  if (includedFiles.length === 0) {
+  if (includedFiles.length === 0 && config != null) {
     return new Map();
   }