Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

430 number dragger should work outside editor #877

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

IBurntMyBagel
Copy link
Collaborator

Current Behavior: Allows the user to drag the number outside the code editor tab. Displays a preview of the number value above the number being dragged.
Changed: No longer updates the value of the number being dragged in real time and now updates the value when user stops dragging number.

@IBurntMyBagel IBurntMyBagel requested a review from curran November 19, 2024 21:42
Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a good idea in a way, it defeats the entire purpose of the interactive widgets, which is to trigger real-time updates to the code so that users can interactively tweak values, and that tweaking works well with hot reloading.

The requirement for the issue is to preserve the real-time updates to the code, while also having it work outside the editor area. My apologies if this was not clear.

@IBurntMyBagel
Copy link
Collaborator Author

Ah no worries. I understand the importance of keeping the updating in real time feature for the number dragger. Since it's currently able to be dragged off screen, I'll try and work on the issue more and get it to update while off screen as the next step.

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants