-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second fix for back button #746
Open
d-nieto246
wants to merge
2
commits into
main
Choose a base branch
from
new-fix-back-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -12,6 +12,7 @@ import { setIsDocOpenReducer } from './setIsDocOpenReducer'; | |||||
import { setThemeReducer } from './setThemeReducer'; | ||||||
import { editorNoLongerWantsFocusReducer } from './editorNoLongerWantsFocusReducer'; | ||||||
import { setUsernameReducer } from './setUsernameReducer'; | ||||||
import { setTabListReducer } from './setTabListReducer'; // Imported a new reducer | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
export { createInitialState } from './createInitialState'; | ||||||
|
||||||
|
@@ -41,8 +42,8 @@ export type VZState = { | |||||
|
||||||
// The shape of the actions that can be dispatched to the reducer. | ||||||
export type VZAction = | ||||||
// `set_active_file_id` | ||||||
// * Sets the active file ID. | ||||||
// `set_active_file_id` | ||||||
// * Sets the active file ID. | ||||||
| { type: 'set_active_file_id'; activeFileId: FileId } | ||||||
|
||||||
// `set_active_file_left' 'set_active_file_right` | ||||||
|
@@ -54,16 +55,16 @@ export type VZAction = | |||||
// `open_tab` | ||||||
// * Opens a tab. | ||||||
// * Also serves to change an already open transient tab to persistent. | ||||||
| { | ||||||
type: 'open_tab'; | ||||||
fileId: FileId; | ||||||
isTransient?: boolean; | ||||||
} | ||||||
| { type: 'open_tab'; fileId: FileId; isTransient?: boolean; } | ||||||
|
||||||
// `close_tabs` | ||||||
// * Closes a set of tabs. | ||||||
| { type: 'close_tabs'; fileIdsToClose: Array<FileId> } | ||||||
|
||||||
// `set_tab_list` | ||||||
// * Sets the tab list. | ||||||
| { type: 'set_tab_list'; tabList: Array<TabState> } | ||||||
|
||||||
// `set_theme` | ||||||
// * Sets the theme. | ||||||
| { type: 'set_theme'; themeLabel: ThemeLabel } | ||||||
|
@@ -111,6 +112,7 @@ const reducers = [ | |||||
setIsDocOpenReducer, | ||||||
editorNoLongerWantsFocusReducer, | ||||||
setUsernameReducer, | ||||||
setTabListReducer, | ||||||
]; | ||||||
|
||||||
export const vzReducer = ( | ||||||
|
@@ -121,4 +123,4 @@ export const vzReducer = ( | |||||
(currentState, currentReducer) => | ||||||
currentReducer(currentState, action), | ||||||
state, | ||||||
); | ||||||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// setTabListReducer.ts | ||
import { VZState, VZAction } from './index'; | ||
|
||
export const setTabListReducer = (state: VZState, action: VZAction): VZState => { | ||
if (action.type !== 'set_tab_list') { | ||
return state; | ||
} | ||
|
||
return { | ||
...state, | ||
tabList: action.tabList, | ||
}; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are used in the keyboard shortcuts. Deleting them will break things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before deleting things, it's a good idea to search for them in the codebase to see if they are used anywhere.