Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first check for desktop app electron #668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

brandonbalchand
Copy link
Contributor

Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thank you so much for working on this.

I have a few points of feedback:

  • When I run npm run dev, I see the following error:
    image
  • I would prefer not to change the existing scripts in package.json, but rather introduce a new one for Electron
  • Let's keep "main": "src/index.ts", for now, since I believe that impacts how we can import from the package. I'm not sure what the benefit of changing this is.
  • The usage of cors seems like it may not be strictly necessary. Perhaps it is, but something worth looking into, if we can remove it as a dependency.

@curran
Copy link
Contributor

curran commented Apr 26, 2024

To summarize the additional changes I'd like to see before merging this:

  • Please revert npm run dev to the same as it was before, so that I and others can continue to develop VZCode without invoking Electron
  • Please add a separate script that starts up the electron app and server, and ideally document in the README the exact commands recommended to start the electron app
  • Please revert the "main": "src/index.ts"
  • Please check if it can still work without the cors dependency

Thank you so much!

@icoco
Copy link

icoco commented May 13, 2024

maybe pkg also is another option
still not done

@curran
Copy link
Contributor

curran commented Jul 4, 2024

Whoah thank you @icoco !

I'd still like to make this happen. Not sure what the easiest path is, but it would be great to be able to do this:

npm install -g vzcode
cd my-local-source-code-dir
vzcode .

then have the app open as an Electron app to edit my files locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants