Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template examples #133

Merged
merged 3 commits into from
Feb 4, 2024
Merged

Fix template examples #133

merged 3 commits into from
Feb 4, 2024

Conversation

Kijewski
Copy link
Contributor

@Kijewski Kijewski commented Feb 4, 2024

  • Use canonical syntax to print items
  • No need to use another HTML escaper
  • Don't convert to bytes by manually copying
  • Don't use | safe in examples

* Use canonical syntax to print items
* No need to use another HTML escaper
A user might copy the code without realizing that they introduce a huge
security risk by skipping escaping.
@Kijewski Kijewski changed the title Fix markup example Fix template examples Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e2746f) 59.98% compared to head (af28a4e) 59.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   59.98%   59.98%           
=======================================
  Files          77       77           
  Lines        5133     5133           
=======================================
  Hits         3079     3079           
  Misses       2054     2054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon
Copy link
Member

fundon commented Feb 4, 2024

Thank you

@fundon fundon merged commit f62fec7 into viz-rs:main Feb 4, 2024
9 checks passed
@Kijewski Kijewski deleted the pr-markup branch February 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants