Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Graceful shutdown and refactor Handler #126

Merged
merged 49 commits into from
Jan 1, 2024

Conversation

fundon
Copy link
Member

@fundon fundon commented Dec 27, 2023

Closes #120, #109

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 208 lines in your changes are missing coverage. Please review.

Comparison is base (2a7836e) 61.30% compared to head (57cc724) 61.14%.
Report is 55 commits behind head on main.

Files Patch % Lines
viz/src/server.rs 63.54% 35 Missing ⚠️
viz/src/tls/rustls.rs 0.00% 16 Missing ⚠️
viz-tower/src/service.rs 0.00% 14 Missing ⚠️
viz-core/src/middleware/otel/metrics.rs 0.00% 13 Missing ⚠️
viz-core/src/middleware/cors.rs 0.00% 12 Missing ⚠️
viz-tower/src/middleware.rs 0.00% 12 Missing ⚠️
viz-core/src/handler/service.rs 0.00% 11 Missing ⚠️
viz/src/tls/native_tls.rs 0.00% 11 Missing ⚠️
viz-handlers/src/embed.rs 0.00% 9 Missing ⚠️
viz-core/src/handler.rs 50.00% 8 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   61.30%   61.14%   -0.16%     
==========================================
  Files          66       72       +6     
  Lines        4760     4998     +238     
==========================================
+ Hits         2918     3056     +138     
- Misses       1842     1942     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon
Copy link
Member Author

fundon commented Dec 31, 2023

If we remove Sync bounds on Handler, the memory will explode. So Sync is required.

@fundon fundon changed the title feat(core): remove Sync bounds on Handler trait feat(core): Graceful shutdown and refactor Handler Dec 31, 2023
@fundon fundon merged commit d663b55 into main Jan 1, 2024
8 of 9 checks passed
@fundon fundon deleted the remove-sync-on-handler branch January 1, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Sync bounds on Handler trait
1 participant