Limit Button styles to those defined in the Comet design guidelines

[jamesricky]

Description

This removes the color prop entirely and only allows our custom values for the variant prop.
The styling of the variants is not yet correct and will be fixed in a separate PR.

Acceptance criteria

• I have verified if my change requires an example
• I have verified if my change requires a changeset
• I have verified if my change requires screenshots/screencasts

Open TODOs/questions

• Add changeset
• Shoud this be a V8 thing? We might be able to implement this using the MUI theme then 🤔

Further information

• Task: https://vivid-planet.atlassian.net/browse/COM-1479
• Styling will be fixed with: https://vivid-planet.atlassian.net/browse/COM-1393

[johnnyomair]

I'm unsure if this is a good idea. Yes, UX might not have considered all possible combinations that are available in MUI, but they may add/need them in the future. "Our" variant prop would then become increasingly complex/bloated.

[jamesricky]

I'm unsure if this is a good idea. Yes, UX might not have considered all possible combinations that are available in MUI, but they may add/need them in the future. "Our" variant prop would then become increasingly complex/bloated.

I specifically asked UX about which variants they need as we (me and UX) want to prevent devs from using combinations of MUIs variant and color that are not allowed, according to UX. This list should cover their needs for the foreseeable future.

[johnnyomair]

I specifically asked UX about which variants they need as we (me and UX) want to prevent devs from using combinations of MUIs variant and color that are not allowed, according to UX.

We don't do this for other components, e.g., Typography. I'm not a fan of removing MUI functionality just because UX hasn't thought about a use case (yet). Our devs should be able to use the MUI docs as a primary source. And IMO we can expect devs to think. They can always use sx if they want to change the background to a color UX doesn't allow. Or would you remove that as well? 😉

But I don't care too much about it. If we find that it wasn't a good idea, we can change it back. 🤷🏼‍♂️

[jamesricky]

And IMO we can expect devs to think.

I don't want to think if I don't have to 😅

I see your point, maybe we can discuss this next week, this doesn't have any priority 🙂

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[johnnyomair]

Discussed this internally and decided to go with the single variant prop for now. 🙂