New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SVG validation #2968

Open

thomasdax98 wants to merge 1 commit into main from improve-svg-validation

Member

thomasdax98 commented Dec 19, 2024 •

edited

Loading

Description

Improve SVG validation

Following tags are banned in SVGs:

script
[new] foreignObject
[new] use
[new] image
[new] animate
[new] animateMotion
[new] animateTransform
[new] set

Following attributes are banned:

Event handlers (onload, onclick, ...)
[new] href and xlink:href (if the value starts with http://, https:// or javascript:)

Acceptance criteria

I have verified if my change requires an example
I have verified if my change requires a changeset
I have verified if my change requires screenshots/screencasts

Screenshots/screencasts

Bildschirmfoto 2024-12-19 um 15 59 18

Further information

Task: https://vivid-planet.atlassian.net/browse/PHSB2C-4334

thomasdax98 marked this pull request as ready for review

December 19, 2024 15:20

auto-assign bot requested a review from johnnyomair

December 19, 2024 15:20

auto-assign bot assigned thomasdax98


          Improve SVG validation

1aa6282

thomasdax98 force-pushed the improve-svg-validation branch from de194d3 to 1aa6282 Compare

December 20, 2024 08:12

sonarqubecloud bot commented Dec 20, 2024

Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet