Add info alert for dependents and duplicates in DAM #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdax98
requested review from
thomasdax98
and removed request for
johnnyomair
nsams
reviewed
Aug 26, 2024
thomasdax98
reviewed
Sep 5, 2024
johnnyomair
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Since we're using American English, please change to dependents: https://www.merriam-webster.com/grammar/spelling-variants-dependent-vs-dependant
|
Should it be possible to "remove" this info boxes? Maybe by storing the information in the local storage? IMO they are very prominent... |
I don't think that's necessary since they are below the DataGrid so they aren't annoying. They look very prominent on the screenshot because the Grids are empty / almost empty. In a real application this won't be the case. |
johnnyomair
changed the title
johnnyomair
approved these changes
Sep 10, 2024
thomasdax98
approved these changes
Sep 10, 2024
thomasdax98
deleted the
COM-102-info-box-for-duplicates-and-dependents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Screenshots/screencasts
Dependants:Duplicates: