Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize the size and alignment of the DAM filters #2463

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

fichtnerma
Copy link
Contributor

@fichtnerma fichtnerma commented Aug 23, 2024


Unify DAM Filter Dropdowns

PR Checklist

  • Verify if the change requires a changeset. See CONTRIBUTING.md
  • Link to the respective task if one exists: COM-1029
  • Provide screenshots/screencasts if the change contains visual changes
Screenshots/screencasts

image

@thomasdax98
Copy link
Member

@fichtnerma It would be great if it also aligned with the search field. Could you look into that too?

@thomasdax98 thomasdax98 requested review from thomasdax98 and removed request for johnnyomair August 26, 2024 09:20
}}
/>
</Typography>
{/* <Typography variant="body1"> */}
Copy link
Member

@thomasdax98 thomasdax98 Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not needed, then remove it instead of commenting it

Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a Data Grid toolbar?

.changeset/green-ants-play.md Outdated Show resolved Hide resolved
@johnnyomair johnnyomair changed the title Unify DAM Filter Dropdowns Harmonize the size and alignment of the DAM filters Sep 10, 2024
@fichtnerma
Copy link
Contributor Author

Shouldn't this be a Data Grid toolbar?

Part of this ticket is only fixing the alignment of the filters. I think the switch to datagrid will be done seperatly

Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for @thomasdax98' approval

@thomasdax98 thomasdax98 merged commit b721ac0 into main Nov 22, 2024
11 checks passed
@thomasdax98 thomasdax98 deleted the COM-1029-dam-unify-dropdown-sizes branch November 22, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants