Admin Generator (Future): Forward selectionProps to support implementing AssignGrid #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. it's possible to use the generated grid as select-grid or style something
Ben-Ho
force-pushed
the
admin-gen-configurable_forward-data-grid-props
branch
from
2612c3f to
fa86c98
Compare
Ben-Ho
changed the title
nsams
reviewed
Aug 22, 2024
nsams
reviewed
Sep 12, 2024
| @@ -41,7 +41,7 @@ function findQueryTypeOrThrow(queryName: string, schema: IntrospectionQuery) { | |||
| return ret; | |||
| } | |||
|
|
|||
| export type Prop = { type: string; optional: boolean; name: string }; | |||
| export type Prop = { type: string; optional: boolean; name: string; destructionAlias?: string }; | |||
There was a problem hiding this comment.
destructionAlias is not used, what are the plans with it?
There was a problem hiding this comment.
I'm not using it anymore. I'm removing it.
johnnyomair
reviewed
Sep 25, 2024
|
@johnnyomair I hope merge-main solves the lint-issue |
johnnyomair
reviewed
Nov 11, 2024
johnnyomair
reviewed
Nov 20, 2024
johnnyomair
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement
Set
selectionPropsfrom outside to use the generated grid as select-grid (see #2428).Solution
Simply add selection-specific props and merge with already existing
dataGridPropsconst.Open issues