Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility for uncontrolled (promise-based) behavior to FeedbackButton #2425

Merged
merged 13 commits into from
Sep 9, 2024
Merged

Add possibility for uncontrolled (promise-based) behavior to FeedbackButton #2425

merged 13 commits into from
Sep 9, 2024

Conversation

jomunker
Copy link
Contributor

@jomunker jomunker commented Aug 14, 2024 •
edited by johnnyomair
Loading

Previously the FeedbackButton was controlled by the props loading and hasErrors. To enable more use cases and easier usage, a promise-based way was added. If neither of the mentioned props are passed, the component uses the promise returned by onClick to evaluate the idle, loading and error state.

PR Checklist

  • Verify if the change requires a changeset. See CONTRIBUTING.md
  • Link to the respective task if one exists: COM-754
  • Provide screenshots/screencasts if the change contains visual changes
Screenshots/screencasts
Screen.Recording.2024-08-14.at.11.38.43.mov

@jomunker
feat(CrudContextMenu): use FeedbackButton in DeleteDialog
ae22fe2
@jomunker
fix(FeedbackButton): never setting display state to error
4018109
@jomunker
refactor(FeedbackButton): by removing redundant code and simplifying …
68cffdc 
…code
@jomunker
feat(FeedbackButton): optimize conditions to ensure correct behaviour…
f4e3311 
… of loading, disabled and the tooltip
@jomunker
docs(DeleteDialog): add changeset for the usage of the FeedbackButton
f014d2e
@jomunker
feat(FeedbackButton): add possibility for promise-based behaviour
7c4e493
@jomunker
feat(CrudContextMenu): adapt promise-based FeedbackButton usage for D…
2aec58b 
…eleteDialog
@jomunker
docs(FeedbackButton): update and add more stories that showcase the c…
91b13f3 
…ontrolled and uncontrolled option
@jomunker
docs(FeedbackButton): add a changeset for the addition of the promise…
52da7ac 
…-based behaviour
@jomunker jomunker self-assigned this Aug 14, 2024
@jomunker jomunker mentioned this pull request Aug 14, 2024
Closed
3 tasks
@jomunker
Copy link
Contributor Author

I will ready it for review once #2423 is merged

Base automatically changed from COM-754-delete-dialog-feedback-button to main August 14, 2024 12:04
@jomunker jomunker marked this pull request as ready for review August 14, 2024 12:16
@johnnyomair johnnyomair requested a review from nsams August 14, 2024 12:28
@johnnyomair johnnyomair changed the title Add possibility for uncontrolled (promise-based) behaviour to FeedbackButton Add possibility for uncontrolled (promise-based) behavior to FeedbackButton Aug 14, 2024
@johnnyomair johnnyomair changed the title Add possibility for uncontrolled (promise-based) behavior to FeedbackButton Add possibility for uncontrolled (Promise-based) behavior to FeedbackButton Aug 14, 2024
@johnnyomair johnnyomair changed the title Add possibility for uncontrolled (Promise-based) behavior to FeedbackButton Add possibility for uncontrolled (promise-based) behavior to FeedbackButton Aug 14, 2024
johnnyomair
johnnyomair reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 👍🏼

.changeset/quiet-kangaroos-give.md Outdated Show resolved Hide resolved
@jomunker @johnnyomair
docs: Update changeset
a1aaf8f 
Co-authored-by: Johannes Obermair <[email protected]>
@jomunker jomunker requested a review from johnnyomair August 16, 2024 06:27
jamesricky
jamesricky previously approved these changes Aug 19, 2024
View reviewed changes
nsams
nsams previously approved these changes Aug 23, 2024
View reviewed changes
@jamesricky jamesricky dismissed stale reviews from nsams and themself via 38471e6 September 3, 2024 09:03
@jomunker jomunker requested review from nsams and jamesricky September 3, 2024 09:17
@thomasdax98 thomasdax98 removed their request for review September 9, 2024 12:33
@johnnyomair johnnyomair merged commit bef162a into main Sep 9, 2024
11 checks passed
@johnnyomair johnnyomair deleted the COM-754-add-promise-behaviour-to-feedback-button branch September 9, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

@jamesricky jamesricky jamesricky approved these changes

@nsams nsams nsams approved these changes

Assignees

@jomunker jomunker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jomunker @nsams @jamesricky @johnnyomair