FinalFormSelect: Fix value 0 and false not being clearable (#2523)

Fix bug that made the number 0 unclearable when used as a value inside a SelectField. --------- Co-authored-by: Markus Fichtner <[email protected]> Co-authored-by: Ricky James Smith <[email protected]>
vivid-planet · Sep 17, 2024 · bc1ed88 · bc1ed88
1 parent 3b0dd14
commit bc1ed88
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/six-vans-hang.md b/.changeset/six-vans-hang.md
@@ -0,0 +1,5 @@
+---
+"@comet/admin": patch
+---
+
+FinalFormSelect: Fix value `0` and `false` not being clearable
diff --git a/packages/admin/admin/src/form/FinalFormSelect.tsx b/packages/admin/admin/src/form/FinalFormSelect.tsx
@@ -47,7 +47,7 @@ export const FinalFormSelect = <T,>({
     const endAdornment = !required ? (
         <ClearInputAdornment
             position="end"
-            hasClearableContent={Boolean(multiple ? (Array.isArray(value) ? value.length : value) : value)}
+            hasClearableContent={Boolean(multiple ? (Array.isArray(value) ? value.length : value !== undefined) : value !== undefined)}
             onClick={() => onChange(multiple ? [] : undefined)}
         />
     ) : null;