Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split selectorLabels into selectorLabels and selectorMatchLabels #124

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Vierlip
Copy link
Contributor

@Vierlip Vierlip commented Dec 19, 2024

  • Add selectorMatchLabels definition in comet-admin, comet-api and comet-site templates.
  • Update deployment.yaml to use selectorMatchLabels instead of selectorLabels.
  • This change allows modifying pod labels without using additionalPodLabels and without changing the matchLabels section.
  • Previous PR: Add app label to API and Admin charts #122

@Vierlip Vierlip self-assigned this Dec 19, 2024
@Vierlip Vierlip merged commit fd1b6da into main Dec 19, 2024
2 checks passed
@kaufmo kaufmo deleted the split-selectorLables-matchLabels-labels branch December 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants