feat: extend File.write() to accept a rootnode and foldername
#1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phorward
changed the title
File.write() to accept a rootnode and foldername
sveneberth
requested changes
Oct 30, 2024
sveneberth
added
feature
sveneberth
approved these changes
Nov 6, 2024
ArneGudermann
approved these changes
Nov 7, 2024
phorward
requested changes
Nov 11, 2024
| rootnode = self.ensureOwnModuleRootNode() | ||
| elif not foldername: | ||
| # if rootnode is set and foldername is not, save the file in the root of the rootnode | ||
| foldername = [] |
There was a problem hiding this comment.
I like tuples ;)
Suggested change
| foldername = [] | |
| foldername = () |
| if foldername is not None: | ||
| foldernames = foldername | ||
| if isinstance(foldername, str): | ||
| foldernames = foldernames.replace('\\', '/') |
There was a problem hiding this comment.
I'm not sure if we should handle this case. What do the others think? @sveneberth?
There was a problem hiding this comment.
Since this write method is only for internal usage and we don't expect pathes from client users I don't see the necessity of it.
| foldernames = foldername | ||
| if isinstance(foldername, str): | ||
| foldernames = foldernames.replace('\\', '/') | ||
| foldernames = (i for i in foldernames.split('/')) |
There was a problem hiding this comment.
Suggested change
| foldernames = (i for i in foldernames.split('/')) | |
| foldernames = foldernames.split("/") |
| if isinstance(foldername, str): | ||
| foldernames = foldernames.replace('\\', '/') | ||
| foldernames = (i for i in foldernames.split('/')) | ||
| foldernames = (i for i in foldernames if i) |
There was a problem hiding this comment.
Suggested change
| foldernames = (i for i in foldernames if i) | |
| foldernames = tuple(foldernames) # ensure tuple, run any iterators |
sveneberth
requested changes
Nov 20, 2024
| .filter("name", fname) | ||
| .getSkel()) | ||
| if currentfolder: | ||
| parentfolderkey = currentfolder.key |
There was a problem hiding this comment.
Since getSkel() returns an SkeletonInstance, skel.key would be a the KeyBone key (or am I wrong?).
Suggested change
| parentfolderkey = currentfolder.key | |
| parentfolderkey = currentfolder["key"] |
| if foldername is not None: | ||
| foldernames = foldername | ||
| if isinstance(foldername, str): | ||
| foldernames = foldernames.replace('\\', '/') |
There was a problem hiding this comment.
Since this write method is only for internal usage and we don't expect pathes from client users I don't see the necessity of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: extend the write()-method of File to accept a rootnode and foldername