Add templates for second factor user authentication #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveneberth
reviewed
Aug 11, 2023
3 tasks
sveneberth
requested changes
Aug 30, 2023
There was a problem hiding this comment.
These templates looks okay, but you missed the user_login_secondfactor. Take a look at ArneGudermann#1
…emplates Adjust template `user_login_secondfactor`
sveneberth
approved these changes
Sep 1, 2023
|
After viur-framework/viur-core#578 is merged, we can merge this one. Thäänk yuuuuhh @ArneGudermann |
sveneberth
reviewed
Sep 5, 2023
sveneberth
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Hey @ArneGudermann,
I adjusted the templates again (hopefully the last time). I did this directly in your pr for simplicity, hope that was ok.
During this I discovered some bugs/mistakes in viur-core and created the PRs:
- fix: import qrcode's element with an alias viur-core#844
- fix: template name should not be static. viur-core#845
- fix some mixed up and blurred methods and concepts. viur-core#846
I tested the templates with this merge-branch: https://github.com/sveneberth/viur-core/tree/develop_with_bugfixes
sveneberth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The templates for #578.