Migrate to UUIDs #572
Merged
Migrate to UUIDs #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWerm
reviewed
Nov 22, 2022
...ests/src/tools/vitruv/framework/views/changederivation/BasicStateChangePropagationTest.xtend
Outdated
Show resolved
Hide resolved
TomWerm
approved these changes
Nov 22, 2022
added 7 commits
December 13, 2022 09:38
copy UUIDs to identity view
adapt view tests to enforce non-null UUID resolver
added 7 commits
December 13, 2022 09:48
…therwise transactions on the shared UUID resolver are ended before all IDs are assigned
…ith elements of the actually provided resource set instead of ones from the internally used resource set
added 4 commits
February 5, 2023 11:21
# Conflicts: # bundles/tools.vitruv.framework.views/src/tools/vitruv/framework/views/changederivation/StateBasedChangeResolutionStrategy.xtend # bundles/tools.vitruv.framework.views/src/tools/vitruv/framework/views/impl/ChangeDerivingView.xtend # bundles/tools.vitruv.framework.views/src/tools/vitruv/framework/views/impl/ChangeRecordingView.xtend # bundles/tools.vitruv.framework.views/src/tools/vitruv/framework/views/impl/IdentityMappingViewType.xtend # tests/tools.vitruv.framework.views.tests/src/tools/vitruv/framework/views/changederivation/BasicStateChangePropagationTest.xtend # tests/tools.vitruv.framework.views.tests/src/tools/vitruv/framework/views/changederivation/StateChangePropagationTest.xtend # tests/tools.vitruv.framework.views.tests/src/tools/vitruv/framework/views/impl/ChangeDerivingViewTest.java # tests/tools.vitruv.framework.views.tests/src/tools/vitruv/framework/views/impl/IdentityMappingViewTypeTest.java
HansMartinA
reviewed
Feb 22, 2023
...ls.vitruv.framework.views/src/tools/vitruv/framework/views/impl/IdentityMappingViewType.java
Outdated
Show resolved
Hide resolved
...ls.vitruv.framework.views/src/tools/vitruv/framework/views/impl/IdentityMappingViewType.java
Outdated
Show resolved
Hide resolved
h4uges
reviewed
Apr 3, 2023
...ls.vitruv.framework.views/src/tools/vitruv/framework/views/impl/IdentityMappingViewType.java
Outdated
Show resolved
Hide resolved
...ools.vitruv.framework.vsum/src/tools/vitruv/framework/vsum/helper/VsumFileSystemLayout.xtend
Outdated
Show resolved
Hide resolved
| } | ||
| modelUris = Files.readAllLines(fileSystemLayout.getModelsNamesFilesPath()).stream().map(URI::createURI) | ||
| .toList(); | ||
|
|
||
| } catch (NoSuchFileException e) { | ||
| // There are no existing models, so don't do anything |
There was a problem hiding this comment.
Just for clarification: There could be a case where the model is not saved and we want to read it?
There was a problem hiding this comment.
At least when then repository is created initially, i.e. there are no repository files yet created, this could be the case. In any other case, I would expect an existing serialisation. (But this discussion is not really part of this PR, right?)
TomWerm
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the V-SUM to use UUIDs within its changes while preserving hierarchical IDs for any view (adapting to vitruv-tools/Vitruv-Change#47). The conversion from HID-based changes to UUID-based ones happens in the
IdentityMappingViewType.ResourceRepositoryImplto use one change recorder instead of multiple ones. I must admit that I don't fully recall why I added this change. I guess it was before I separated change recording and UUID assignment as sharing a UUID resolver over multiple recorders might be problematic. Anyways, it does not change functionality and makes the code easier to read, thus I would suggest to keep that change.There is one code duplication regarding assigning hierarchical IDs to changes. As we should refactor hierarchical ID and UUID resolvers to be hidden behind the same
IDResolverinterface I postponed refactoring this code smell to when such interface exists. I would document it accordingly in an issue.