Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vttablet-modes.md #244

Closed
wants to merge 1 commit into from
Closed

Conversation

dhruv-bansal
Copy link

grammatical error correction

grammatical error correction
@morgo morgo self-requested a review July 31, 2019 18:06
@morgo
Copy link
Contributor

morgo commented Jul 31, 2019

@dhruv-bansal Thank you for the PR! CI is failing because Vitess requires a DCO (commit -s), which is not currently possible via GitHub.com. (Edit: Sorry, this is a known issue. We are discussing the best way to fix.)

Would you like to try resubmitting this with DCO? Otherwise I can incorporate into another PR I have with various spelling fixes: #231

@morgo morgo added the requires-branch-change This PR is based on master and not prod label Aug 1, 2019
morgo added a commit to planetscale/vitess-website that referenced this pull request Aug 10, 2019
Remove inconsistent double spacing after '.'
Capitalize "MySQL" and "Vitess"
Fix vitessio#244
Fix vitessio#184
Fix vitessio#140

Signed-off-by: Morgan Tocker <[email protected]>
@morgo morgo mentioned this pull request Aug 10, 2019
@morgo morgo closed this in #258 Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-branch-change This PR is based on master and not prod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants