Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Edit" on vitess.io #228

Closed
morgo opened this issue Jul 25, 2019 · 1 comment
Closed

Update "Edit" on vitess.io #228

morgo opened this issue Jul 25, 2019 · 1 comment

Comments

@morgo
Copy link
Contributor

morgo commented Jul 25, 2019

The edit link allows you to edit in GitHub, but I believe doing so will create commits without a DCO:

#227

This appears to be a known problem:
todogroup/gh-issues#50

Maybe we should remove the edit link, and just have a create issue link?

@morgo
Copy link
Contributor Author

morgo commented Aug 6, 2019

There is a further issue that the edit link edits master instead of prod. We should fix this at the same time.

@morgo morgo closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant